Repository navigation
Add Axum production startup and bounded shutdown - #406
Open
ChristianPavilonis wants to merge 16 commits into
Open
ChristianPavilonis wants to merge 16 commits into
ChristianPavilonis wants to merge 16 commits into
Conversation
20 of 23 tasks
This was referenced Oct 7, 2026
20 of 22 tasks
11 tasks
ChristianPavilonis
force-pushed
the
issue-392-396-production-hosting-spec
branch
from
November 10, 2026 19:40
3ab2209 to
49ba021
Compare
This was referenced Nov 10, 2026
This was referenced Nov 12, 2026
Collaborator
|
CREATOR: From the server-side identity plan (IABTechLab/trusted-server#1559, Part of #476 |
This was referenced Nov 13, 2026
ChristianPavilonis
changed the base branch from
docs/outbound-http-spec
to
review/pr275-cutover-followup-20261112
November 13, 2026 16:48
ChristianPavilonis
changed the base branch from
review/pr275-cutover-followup-20261112
to
issue-459-outbound-compat
November 13, 2026 17:32
aram356
added a commit
that referenced
this pull request
Nov 14, 2026
aram356
added a commit
that referenced
this pull request
Nov 14, 2026
aram356
added a commit
that referenced
this pull request
Nov 14, 2026
Brings #275 at e9ffaa8 and the refreshed heads of #499, #460, #406, #407, #409, #414, #422 and #439. Each PR merged the one below it, so this merge has no conflicts. Two edits fit #469 to #275, as #469's open review asks: - #469's ingress JA4 test calls into_core_request with one argument. #275 now passes the Axum outbound executor through that function, so the test gets an executor handle the way the other ingress tests do. - The Axum guide names EdgeZeroAxumService, which #275 removes and check_outbound_legacy_api.sh rejects. The guide now names only AxumDevServer::with_trusted_ja4_header.
aram356
added a commit
that referenced
this pull request
Nov 16, 2026
aram356
added a commit
that referenced
this pull request
Nov 17, 2026
17 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current review readiness — 2026-11-10
Ready for review at the publication head below. All29 current hosted checks passed. Reviewers:
aram356,prk-Jr,dhruv8sh.Review transitions are independent of TS work and the combined integration audit; #462 remains draft. This current status supersedes historical draft-only prerequisites below without claiming unexecuted deployment/manual acceptance complete. All three reviewers are requested. Stack465 is the current grouping; #453 is excluded.
Current review-stack checkpoint
Publication head:
9f090e573206cf0d8c21c1ce0067afffd69f12db. This cleanup preserves the existing feature unit and PR identity. The additional change is the completed generated-native build correction: image-only code now follows the scaffold's existing Fastly-example selection, with no request-policy change. Its focused generator/native proof is retained; fresh per-branch hosted checks are not assumed green.Review order: #275 → #406 → #407 → #409 → #414 → #422 → #439 → #454. Draft integration checkpoint: #462. New SDK/group/codec/phase development and unrelated TS work are not prerequisites or additions to this PR. Earlier notes below retain their original tested revisions and limits; they are not a whole-tree pass for this new head.
Earlier implementation and proof notes
RC refresh checkpoint, 2026-11-10
Current head:
1d8e42e1cba52610e6655965e9941f42680b53ab.Current #275 hosting port, with bounded startup/config/ingress and existing callback/egress ownership retained. The invalid-present native-limit and Windows prefix-identity capture bugs found by review are fixed. Windows semantics were simulated at the private parser boundary, not run on Windows.
Fresh CI exposed missing fixture validator metadata, an always-compiled test listener helper and a trigger assertion still expecting main-only PRs. The fixture lock is synced, the helper now has the same test/test-utils gate as its caller, and the exact workflow test now requires all PR bases while retaining main-only push. No lint suppression or production/deployment trigger expansion. Parent proof includes 301 Axum unit tests, axum-only strict Clippy and 35 Node CI tests.
Draft pending fresh hosted checks and the combined RC audit. Two unchanged native default-parallel deadline misses remain recorded and unclassified; serial passes and untouched-foundation parallel passes do not clear them. No timing bound was relaxed. No deployment, main merge, security-alert dismissal or review-thread resolution occurred. Historical design/review context follows.
Summary
This PR is stacked on #275, with base branch
docs/outbound-http-spec. The implementation started at5527b58. It remains draft because #275 has advanced to91f4af38, five parent-only commits beyond the common base5527b58. Parent integration and re-audit, including the previously identifieddev_server.rsconflict, remain outstanding. The recorded checks are for this branch, not integration with the current prerequisite. This relationship audit performed no merge or rebase. Integrate the current contracts and repeat affected validation before marking ready.Changes
edgezero-adapter-axum/src/dev_server.rs,run_options.rsedgezero-core/src/app.rs,router.rsedgezero-core/src/extractor.rs,probe.rsCloses
Closes #392.
Closes #396.
Part of #391. This PR remains draft until the pending integration and acceptance work below is complete.
Remaining acceptance includes production adoption/storage guides, standalone release and Docker UID evidence, unreadable/unusable mount cases, retained-handle lock evidence, and the accepted-#275 re-audit.
Test plan
cargo test --workspace --all-targetscargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo check --workspace --all-targets --features "fastly cloudflare spin"examples/app-demoworkspace:cd examples/app-demo && cargo test --workspace --all-targetscd docs && npm run lint && npm run format && npm run buildedgezero serve --adapter axumcargo test -p edgezero-core --all-targetscargo test -p edgezero-adapter-axum --all-targets --all-features, including all 13 production-hosting subprocess testscargo check -p edgezero-adapter-spin --target wasm32-wasip2 --features spincargo check -p edgezero-core --test production_handlers --target <target>forwasm32-wasip1,wasm32-wasip2, andwasm32-unknown-unknowngit diff --checkChecks passed on this branch, not on a merge with the newer prerequisite. Native subprocess tests use debug fixtures and the current user's UID, not a release container image. Shutdown cancellation is cooperative; blocking application code still requires a supervisor hard-kill boundary.
Checklist
{id}syntax, not:idedgezero_core, nothttpKvRegistry/ConfigRegistry/SecretRegistryTS cutover follow-up, November 11
Adds startup-only router installation without rebuilding application clocks, platform metadata, or admission/egress policies. This lets a prepared-store initializer assemble application routes before the listener is shared.
Current head:
1b5e361e4896ad098fc26925556eb58b52ecdbb6.Local combined-RC qualification at
36f8e9c9c2c93661aaa73f2ca956cec3bc9e4c92: workspace tests 2,947 passed / 6 ignored; all-feature Axum 568 passed, including 36 production-hosting, 6 AWS startup and 4 celld startup cases; core doctests 19 passed / 13 ignored; strict workspace Clippy, formatting, feature compilation and Spin WASM check passed under Rust 1.98.1. Narrow TS consumer proof under Node 24.20.0: all four real proxy tests and typed prepared config/secrets/router startup passed. This is not final TS-stack/image/deployment qualification. Fresh hosted checks are still required.Owned follow-up review checkpoint
a13f68a05c3028dff9a911b22475eb75dc8c883c. Source tree30d6b8ae249b4dd7edd0c0308ebdde8207ebc3c1is byte-identical to previous head6d1dda164bc60459ec91ab5343195fa4f729ad00.docs/outbound-http-specbase are preserved. Only owned branch history was advanced; no update to feat: implement portable outbound HTTP and request lifecycle contracts #275 was made.